Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip FOAF test #277

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Skip FOAF test #277

merged 1 commit into from
Nov 2, 2021

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Nov 1, 2021

Description:

Fixes #276

This simply skips the test, however, it should be moved to examples/ and some documentation should be written around this code to explain what the code is doing - as is suggested in the test's doc-string as well.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

This doesn't truly fix the issue, it merely avoids it for now - even without incorporating the suggested tests mentioned in #276. However, this kind of testing is already done in tests.test_load.test_load_rdfs().
So the actual fix for the current issue is to instead move this to examples/ and use it for documentation.

@CasperWA CasperWA requested a review from francescalb November 1, 2021 13:15
@CasperWA CasperWA merged commit bbf7e8f into master Nov 2, 2021
@CasperWA CasperWA deleted the cwa/fix-276-update-foaf-test branch November 2, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable FOAF test as xmlns.com is down
2 participants